removed username
This commit is contained in:
@@ -54,7 +54,7 @@ func AuthorizeHandler(w http.ResponseWriter, r *http.Request) {
|
||||
}
|
||||
|
||||
log.Print("Authorization request for user=", ctx.UserID, ", resource=", ctx.Resource, ", action=", ctx.Action)
|
||||
log.Print("JWT claims user=", claims.UserID, ", username=", claims.Username, ", role=", claims.RoleID)
|
||||
log.Print("JWT claims user=", claims.UserID, ", role=", claims.RoleID)
|
||||
// Verify JWT user matches request user (security check)
|
||||
if ctx.UserID != claims.UserID {
|
||||
helper.RespondWithError(w, http.StatusForbidden, "User ID mismatch")
|
||||
|
||||
+18
-27
@@ -44,9 +44,8 @@ func TestAuthorizeHandlerNoJWTClaims(t *testing.T) {
|
||||
func TestAuthorizeHandlerInvalidJSON(t *testing.T) {
|
||||
// Setup - no need to init service, we're testing JSON parsing before auth
|
||||
claims := &models.Claims{
|
||||
UserID: "user123",
|
||||
Username: "testuser",
|
||||
RoleID: "admin",
|
||||
UserID: "user123",
|
||||
RoleID: "admin",
|
||||
}
|
||||
|
||||
req := httptest.NewRequest("POST", AuthCheckEndpoint, bytes.NewBufferString("invalid json"))
|
||||
@@ -85,9 +84,8 @@ func TestAuthorizeHandlerMissingRequiredFields(t *testing.T) {
|
||||
for _, tc := range testCases {
|
||||
t.Run(tc.name, func(t *testing.T) {
|
||||
claims := &models.Claims{
|
||||
UserID: "user123",
|
||||
Username: "testuser",
|
||||
RoleID: "admin",
|
||||
UserID: "user123",
|
||||
RoleID: "admin",
|
||||
}
|
||||
|
||||
body, _ := json.Marshal(tc.payload)
|
||||
@@ -108,9 +106,8 @@ func TestAuthorizeHandlerMissingRequiredFields(t *testing.T) {
|
||||
func TestAuthorizeHandlerUserIDMismatch(t *testing.T) {
|
||||
// Setup
|
||||
claims := &models.Claims{
|
||||
UserID: "user123",
|
||||
Username: "testuser",
|
||||
RoleID: "admin",
|
||||
UserID: "user123",
|
||||
RoleID: "admin",
|
||||
}
|
||||
|
||||
payload := models.AuthorizationContext{
|
||||
@@ -137,9 +134,8 @@ func TestAuthorizeHandlerUserIDMismatch(t *testing.T) {
|
||||
func TestAuthorizeHandlerNilMaps(t *testing.T) {
|
||||
// Test that nil maps don't cause additional panics beyond missing authService
|
||||
claims := &models.Claims{
|
||||
UserID: "user123",
|
||||
Username: "testuser",
|
||||
RoleID: "admin",
|
||||
UserID: "user123",
|
||||
RoleID: "admin",
|
||||
}
|
||||
|
||||
payload := models.AuthorizationContext{
|
||||
@@ -175,9 +171,8 @@ func TestAuthorizeHandlerNilMaps(t *testing.T) {
|
||||
|
||||
func TestAuthorizeHandlerEmptyUserID(t *testing.T) {
|
||||
claims := &models.Claims{
|
||||
UserID: "user123",
|
||||
Username: "testuser",
|
||||
RoleID: "admin",
|
||||
UserID: "user123",
|
||||
RoleID: "admin",
|
||||
}
|
||||
|
||||
payload := models.AuthorizationContext{
|
||||
@@ -201,9 +196,8 @@ func TestAuthorizeHandlerEmptyUserID(t *testing.T) {
|
||||
|
||||
func TestAuthorizeHandlerEmptyResource(t *testing.T) {
|
||||
claims := &models.Claims{
|
||||
UserID: "user123",
|
||||
Username: "testuser",
|
||||
RoleID: "admin",
|
||||
UserID: "user123",
|
||||
RoleID: "admin",
|
||||
}
|
||||
|
||||
payload := models.AuthorizationContext{
|
||||
@@ -227,9 +221,8 @@ func TestAuthorizeHandlerEmptyResource(t *testing.T) {
|
||||
|
||||
func TestAuthorizeHandlerEmptyAction(t *testing.T) {
|
||||
claims := &models.Claims{
|
||||
UserID: "user123",
|
||||
Username: "testuser",
|
||||
RoleID: "admin",
|
||||
UserID: "user123",
|
||||
RoleID: "admin",
|
||||
}
|
||||
|
||||
payload := models.AuthorizationContext{
|
||||
@@ -268,9 +261,8 @@ func TestAuthorizeHandlerInvalidClaimsType(t *testing.T) {
|
||||
|
||||
func TestAuthorizeHandlerMalformedJSON(t *testing.T) {
|
||||
claims := &models.Claims{
|
||||
UserID: "user123",
|
||||
Username: "testuser",
|
||||
RoleID: "admin",
|
||||
UserID: "user123",
|
||||
RoleID: "admin",
|
||||
}
|
||||
|
||||
testCases := []struct {
|
||||
@@ -325,9 +317,8 @@ func TestAuthorizeHandlerSpecialCharactersInFields(t *testing.T) {
|
||||
|
||||
// Update claims to match userID
|
||||
testClaims := &models.Claims{
|
||||
UserID: tc.userID,
|
||||
Username: "testuser",
|
||||
RoleID: "admin",
|
||||
UserID: tc.userID,
|
||||
RoleID: "admin",
|
||||
}
|
||||
ctx := context.WithValue(req.Context(), models.ContextKey("claims"), testClaims)
|
||||
req = req.WithContext(ctx)
|
||||
|
||||
Reference in New Issue
Block a user